La procédure stockée SQL ne parvient pas à mettre à jour les données pendant que le script fonctionne manuellement

Question

J'ai un script SQL que j'exécute dans un travail pour transformer des tables périodiquement. Pour l'accélérer, j'ai mis ce script dans une procédure stockée et l'ai exécuté avec un travail. Cela a fonctionné plus vite.

Le problème se produit au moment où la procédure stockée, même si elle l'exécute ne fonctionne pas. J'utilise le script manuellement et l'exécute et tout fonctionne bien.

Le script entier est dans une transaction et j'ai fait en sorte que si une erreur survient, elle soit correctement enregistrée. Cependant, le script ne donne aucune erreur.

---

BEGIN TRANSACTION 
BEGIN TRY 

-- Rounding off Campaign stats 
update Campaigns 
set ImpressionsBurned = ImpressionTarget 
where ImpressionsBurned > ImpressionTarget and CampaignTypeID = 1 

update Campaigns 
set ClicksConsumed = ClickTarget 
where ClicksConsumed = ClickTarget and CampaignTypeID = 2 

-- Updating Campaigns & Banners 
update banners 
set banners.impressionsburned = 
    (select sum(impressionsqueue.impressionsburned) from impressionsqueue where impressionsqueue.bannerid = banners.bannerid) 
where exists (select impressionsqueue.bannerid from impressionsqueue where impressionsqueue.bannerid = banners.bannerid) 

update Campaigns 
set ImpressionsBurned = 
    (select isnull(SUM(ImpressionsQueue.ImpressionsBurned),0) from ImpressionsQueue 
    inner join Banners on Banners.BannerID = ImpressionsQueue.BannerID and CampaignID = Campaigns.CampaignID 
    ) 
where 
    exists (
     (select ImpressionsQueue.BannerID from ImpressionsQueue 
     inner join Banners on Banners.BannerID = ImpressionsQueue.BannerID and CampaignID = Campaigns.CampaignID 
     ) 
    ) 
    and 
    (
    (Campaigns.ImpressionsBurned < Campaigns.ImpressionTarget and Campaigns.CampaignTypeID = 1) 
    or (Campaigns.ClicksConsumed < Campaigns.ClickTarget and Campaigns.CampaignTypeID = 2) 
    or Campaigns.CampaignTypeID = 3 
    ) 
    and Campaigns.IsPaused = 0 
    and Campaigns.StartsOn <= GetDate() and Campaigns.EndsOn >= GetDate() 

-- Updating Paused Banners in the Queue 
update ImpressionsQueue 
set IsPaused = (
    select IsPaused from Banners where Banners.BannerID = ImpressionsQueue.BannerID 
) 
-- Updating the Navigation URLs 
update ImpressionsQueue 
set NavigateURL = (
    select NavigateURL from Banners where Banners.BannerID = ImpressionsQueue.BannerID 
) 

-- Removing any rows if the Weight of a banner is updated, 
-- the banner will be reinserted later with updated impressions 
delete from ImpressionsQueue 
where BannerID in 
( 
    select ImpressionsQueue.BannerID from ImpressionsQueue 
    inner join Banners on Banners.BannerID = ImpressionsQueue.BannerID 
    group by ImpressionsQueue.BannerID, Banners.Weight 
    having Banners.Weight <> COUNT(ImpressionsQueue.BannerID) 
) 

-- Removing entries whose impressions count has reached its target 
delete from impressionsqueue where 
BannerID in (
    select Banners.BannerID from impressionsqueue 
    inner join Banners on banners.bannerid = impressionsqueue.bannerid 
    inner join campaigns on campaigns.campaignid = banners.campaignid 
    where Campaigns.CampaignTypeID = 1 
    -- excluding flat fee based campaign 
    group by Campaigns.ImpressionTarget, Banners.BannerID 
    having not (Campaigns.ImpressionTarget > sum(ImpressionsQueue.impressionsburned)) 
    -- inverse logic for campaign count 
) 
-- Removing entries whose campaign click count has reached 
delete from impressionsqueue where 
BannerID in (
    select Banners.BannerID from impressionsqueue 
    inner join Banners on banners.bannerid = impressionsqueue.bannerid 
    inner join campaigns on campaigns.campaignid = banners.campaignid and Campaigns.CampaignTypeID = 2 
     and Not (Campaigns.ClickTarget > Campaigns.ClicksConsumed) 
    -- inverse logic for campaign count 
) 
-- Removing entries whose campaign has expired 
delete from impressionsqueue where 
BannerID in (
    select impressionqueueid from impressionsqueue 
    inner join Banners on banners.bannerid = impressionsqueue.bannerid 
    inner join campaigns on campaigns.campaignid = banners.campaignid 
     and not (Campaigns.StartsOn <= GETDATE() and Campaigns.EndsOn >= GETDATE()) 
    -- inverse logic for date 
) 

---------------------------------------------------------------------------------------- 
-- Begin updating Impressions Queue 
---------------------------------------------------------------------------------------- 


Declare @TempBanners Table(BcID [int] IDENTITY(1,1),ZoneID [int], BannerID [int], Weight [int], FileID [uniqueidentifier], IsPaused [bit], Impressions [int], URL [nvarchar](2048)) 

/* 
Insert into the temp table all the banners that: 
     1) Belong to an active campaign => c.StartsOn <= GetDate() and c.EndsOn >= GetDate() 
     2) and Belong to a campaign that is not paused 
     3) and The banner itself is not paused 
     4) and Flat Fee campaign banner 
*/ 
Insert Into @TempBanners (ZoneID, BannerID, Weight, FileID, IsPaused, Impressions, URL) 
Select 
     bz.ZoneID, 
     b.BannerID, 
     b.Weight, 
     b.FileID, 
     b.IsPaused, 
     b.ImpressionsBurned, 
     b.NavigateURL 
From Banners b 
Join Bannerzones bz on b.BannerID = bz.BannerID 
Join Campaigns c on b.CampaignID = c.CampaignID 
And c.StartsOn <= GetDate() and c.EndsOn >= GetDate() 
And c.IsPaused = 0 
And b.IsPaused = 0 
And (
      (c.CampaignTypeID = 1 And c.ImpressionsBurned < c.ImpressionTarget) 
      Or (c.CampaignTypeID = 2 And c.clicksconsumed < c.clicktarget) 
      Or (c.campaigntypeid = 3) 
    ); 

-- Declaration of Vairables  
Declare @index As int,@maxRow As int, @weight Int, @bcid int 
Set @index = 1 --Because we will start from First row 
Select @maxRow = Count(0) From @TempBanners Where Weight > 1 
-- How many rows we have that has weight more then 1 
While(@index <= @maxRow) 
Begin 
     Select 
      @weight = V.Weight, 
      @bcid = V.BcID 
     From (
        Select 
         BCid, 
         Weight, 
         ROW_NUMBER() Over (Order By Bcid Asc) Row 
        From @TempBanners 
        Where Weight > 1 
      )V 
     Where V.Row = @index 

     Set @index = @index + 1 

     While(@weight <> 1) 
     Begin 
      Insert Into @TempBanners (ZoneID, BannerID, Weight, FileID, URL) 
      Select ZoneID, BannerID, Weight, FileID, URL From @TempBanners Where BcID = @bcid 
      set @weight = @weight - 1 
     End 
End 

-- INSERT INTO THE IMPRESSION QUEUE ALL THE BANNERS THAT ARE NOT YET IN THE QUEUE 
Insert Into ImpressionsQueue (BannerID, ZoneID, FileID, ImpressionsBurned, RowUpdated, IsPaused, NavigateURL) 
Select V.BannerID, V.ZoneID, V.FileID, V.Impressions, GETDATE(), V.IsPaused, V.URL 
From 
(
     Select m.BannerID, m.ZoneID, m.FileID, 
     isnull(m.IsPaused,0) as IsPaused, 
     isnull(m.Impressions,0) as Impressions, 
     ISNULL(m.URL,'') as URL 
     From @TempBanners m 
     where Weight > 
      (select COUNT(t.bannerid) 
      from ImpressionsQueue as t 
      where t.BannerID = m.BannerID 
       and t.FileID = m.FileID 
       and t.ZoneID = m.ZoneID 
       )  
)As V; 

-- Update the banner file id in case it is modified after the banner was created 
Update ImpressionsQueue 
Set FileID = CTE.FileID, ImpressionsQueue.IsPaused = isnull(CTE.IsPaused,0), ImpressionsQueue.NavigateURL = CTE.URL 
From ImpressionsQueue I 
Inner Join @TempBanners As CTE On CTE.BannerID = I.BannerID And CTE.ZoneID = I.ZoneID --And CTE.FileID <> I.FileID 

---------------------------------------------------------------------------------------- 
-- End updating Impressions Queue 
---------------------------------------------------------------------------------------- 


END TRY 
BEGIN CATCH 
    declare @error varchar(3000) = 'Message: ' + ERROR_MESSAGE() + ' ' + ERROR_LINE() 
    exec master.sys.xp_logevent 50001, @error , 'Warning' 
    IF @@TRANCOUNT > 0 
     ROLLBACK TRANSACTION 
END CATCH 
IF @@TRANCOUNT > 0 
    COMMIT TRANSACTION 

Answer 1

Je ne sais pas si c'est la cause de tout problème - mais si je vous, je mettrais la COMMIT TRANSACTION à l'intérieur du bloc ..... TRY:

------------------------------------------------------------------------------- 
    -- End updating Impressions Queue 
    ------------------------------------------------------------------------------- 
    IF @@TRANCOUNT > 0 
     COMMIT TRANSACTION 
END TRY 
BEGIN CATCH 
    declare @error varchar(3000) = 'Message: ' + ERROR_MESSAGE() + ' ' + ERROR_LINE() 
    exec master.sys.xp_logevent 50001, @error , 'Warning' 
    IF @@TRANCOUNT > 0 
     ROLLBACK TRANSACTION 
END CATCH 

Si tout va bien, vous exécuterez COMMIT TRANSACTION comme dernière instruction de votre bloc TRY ... et si quelque chose explose, vous tomberez dans le bloc CATCH de toute façon. Il peut être dangereux d'appeler COMMIT TRANSACTION en dehors de votre bloc CATCH après ...