Bonne façon d'écrire rspecs dans les rails

Question

Je suis nouveau dans Rspecs donc le code suivant que j'ai écrit est-il correct ... J'ai utilisé Rspec simple. Actuellement Rspec fonctionne correctement, mais les clients potentiels quels sont les changements à faire?
Si quelqu'un peut jeter un oeil à mon code et me aider ce serait apprécié ....

require 'spec_helper' 
require 'rails_helper' 

describe User do 
describe "fails" do 
    it "to create without email" do 
     user = User.create(:first_name => "test", :last_name => "test",:email => "") 
     user.errors.messages[:email][0].should eq "can't be blank" 
    end 
end 

describe "fails" do 
    it "to create without data" do 
     user = User.create(:first_name => "", :last_name => "", :email => "", :status => "") 
     user.errors.messages[:email][0].should eq "can't be blank" 
    end 
end 

describe "fail" do 
    it "to create without a valid email" do 
     user = User.create(:first_name => "", :last_name => "", :email => "test@test1", :status => "") 
     expect(user).to be_valid, lambda { "expected valid email" } 
    end 
end 

describe "pass" do 
    it "to supports 2 letter domain qualifiers" do 
     user = User.create(:first_name => "", :last_name => "", :email => "test@test1.ca", :status => "") 
     user.save! 
    end 
end 

describe "pass" do 
    it "to supports 4 letter domain qualifiers" do 
     user = User.create(:first_name => "", :last_name => "", :email => "test@test1.some", :status => "") 
     user.save! 
    end 
end 
end 

describe "pass" do 
    it "to supports 4 and more letter domain qualifiers" do 
     user = User.create(:first_name => "", :last_name => "", :email => "test@test1.super", :status => "") 
     user.save! 
    end 
end 

describe "pass" do 
    it "to without first name" do 
     user = User.new 
     user.first_name = "" 
     user.last_name = "Test" 
     user.status = "active" 
     user.email = "test127@test.com" 
     user.save! 
    end 
end 

describe "pass" do 
    it "to without last name" do 
     user = User.new 
     user.first_name = "Test" 
     user.last_name = "" 
     user.status = "active" 
     user.email = "test127@test.com" 
     user.save! 
    end 
end 

describe "pass" do 
    it "to without status" do 
     user = User.new 
     user.first_name = "Test" 
     user.last_name = "Test" 
     user.status = "" 
     user.email = "test127@test.com" 
     user.save! 
    end 
end 

describe "pass" do 
    it "to create new record without first name, last name and status" do 
     user = User.create(:first_name => "", :last_name => "", :email => "test@test1.com", :status => "") 
     user.save! 
    end 
end 

describe "pass" do 
    it "to create new record with all parameter" do 
     user = User.new 
     user.first_name = "Test" 
     user.last_name = "Test" 
     user.status = "active" 
     user.email = "test127@test.com" 
     user.save! 
    end 
end 

describe "pass" do 
    it "to update record" do 
     user = User.find_by_id(1127) 
     user.first_name = "Test" 
     user.last_name = "Test" 
     user.status = "active" 
     user.email = "test127@test.com" 
     user.save! 
    end 
end 

Answer 1

1. Vous n'avez pas besoin à la fois spec_helper et rails_helper. spec_helper est déjà requis dans rails_helper. spec_helper est pour les spécifications qui ne dépendent pas de Rails (par exemple des classes dans le répertoire lib). rails_helper est pour les spécifications qui dépendent de Rails (par exemple vos modèles et contrôleurs)
2. Essayez d'exécuter vos spécifications avec le drapeau --format documentation pour voir si vos noms d'exemples et de contextes ont du sens. Dans ce cas, je suis sûr que vous pouvez l'améliorer.

Au lieu de

describe "fails" do 
    it "to create without email" do 
    ... 
    end 
end 

il est plus significatif d'écrire

describe "when creating user without email" do 
    it "adds error" do 
    ... 
    end 
end 

et ainsi de suite. Vous pouvez également ajouter des exemples comme does not create new record

1. Au lieu d'utiliser le modèle directement, vous pouvez utiliser les usines - https://github.com/thoughtbot/factory_girl_rails

2. Vos pass exemples n'ont pas testé quoi que ce soit. Au lieu d'écrire ceci

   user = User.create (...) user.save!

vous pouvez écrire

expect { User.new(...).save }.to change(User, :count).by(1) 

Lorsque vous utilisez des usines, je suis sûr que les spécifications propres devrait ressembler à ce

require 'rails_helper' 

describe User do 
    let(:user) { FactoryGirl.build :user, first_name: 'First name', last_name: 'Last name', email: 'email@gmail.com' } 

    context 'when user want to create account without email' do 
    before { user.email = nil } 

    it 'does not save user record' do 
     expect { user.save }.not_to change(User, :count) 
    end 
    end 
end 

Answer 2

it "fails without email" do 
    user = User.create(:first_name => "test", :last_name => "test",:email => "") 
    user.errors.messages[:email][0].should eq "can't be blank" 
end 

it "fails without parameters" do 
    user = User.create(:first_name => "", :last_name => "", :email => "", :status => "") 
    user.errors.messages[:email][0].should eq "can't be blank" 
end 

it "fails without a valid email" do 
    user = User.create(:first_name => "", :last_name => "", :email => "test@test", :status => "") 
    expect(user).to be_valid, lambda { "expected valid email" } 
end 

it "passes without first name" do 
    pre_count = User.count 
    user = User.new 
    user.first_name = "" 
    user.last_name = "Test" 
    user.status = "active" 
    user.email = "test127@test.com" 
    user.save! 
    count = User.count 
    tot_count = pre_count + 1 
    count.should be tot_count 
    user.email.should eq "test127@test.com" 
    user.first_name.should eq nil 
    user.last_name.should eq "Test" 
    user.status.should eq :active 
end